Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dialog): provide message slot #1536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(dialog): provide message slot #1536

wants to merge 1 commit into from
+16 −4

Conversation

SisIvanova
Copy link
Contributor

Closes #1509

@SisIvanova SisIvanova requested a review from simeonoff January 13, 2025 08:22
rkaraivanov
rkaraivanov requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@rkaraivanov rkaraivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

igniteui-webcomponents/src/components/dialog/dialog.ts

Lines 38 to 40 in 02b1807

* @slot - Renders content inside the default slot.
* @slot title - Renders the title of the dialog header.
* @slot footer - Renders the dialog footer.

  1. Please add a new entry for the message slot in the dialog API section.
  2. If you have not updated the specification, please do so.
  3. Add to the changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov requested changes

@simeonoff simeonoff Awaiting requested review from simeonoff

Requested changes must be addressed to merge this pull request.

Assignees

@simeonoff simeonoff

@didimmova didimmova

Labels
dialog ❌ status: awaiting-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialog content max-width
4 participants
@SisIvanova @rkaraivanov @simeonoff @didimmova