Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify pivot sales data with generated one. #853

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Unify pivot sales data with generated one. #853

merged 1 commit into from
Jan 17, 2025

Conversation

skrustev
Copy link
Member

@skrustev skrustev commented Nov 19, 2024 •
edited
Loading

HUSSAR-mtrela
HUSSAR-mtrela previously requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@HUSSAR-mtrela HUSSAR-mtrela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be better to change generate data which uses newer dates than changing static data to older dates?

@skrustev
Copy link
Member Author

skrustev commented Jan 7, 2025

@HUSSAR-mtrela It already is in the linked PR, this is a custom sample

@dkamburov dkamburov merged commit 375b879 into vnext Jan 17, 2025
2 checks passed
@dkamburov dkamburov deleted the skrastev/fix-pivot-data-custom branch January 17, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkamburov dkamburov dkamburov approved these changes

@HUSSAR-mtrela HUSSAR-mtrela Awaiting requested review from HUSSAR-mtrela

Assignees

@dkamburov dkamburov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skrustev @dkamburov @HUSSAR-mtrela