NSI utils for obtaining NSI data

[ywkim312]

please test it by running test_nsi.py in tests/pyincore_data folder

[navarroc]

Should nsiutil be inside the "utils" folder?

[navarroc]

I see censusutil is also at the top level, which is kind of odd since there is a utils folder. At some point we probably need to think about the structure of pyincore-data. Something like:
pyincore_data / utils / nsiutil
pyincore_data / nsi / nsiparser.py (which calls nsiutil maybe)

or it could be pyincore_data/nsiparser.py

[ywkim312]

Should nsiutil be inside the "utils" folder?

That is a good question. I had a hard time naming it, and there was a censusutil in the same place, so I named it that way. Do you have any other idea for the name of this nsiutil? I think that this file is better positioned in its current location, but maybe the name should be changed. If you propose a different name, I will update the code accordingly.

[ywkim312]

I see censusutil is also at the top level, which is kind of odd since there is a utils folder. At some point we probably need to think about the structure of pyincore-data. Something like: pyincore_data / utils / nsiutil pyincore_data / nsi / nsiparser.py (which calls nsiutil maybe)

or it could be pyincore_data/nsiparser.py

NSI parser sounds good. I will update using this name. Do you have other idea for censusutil as well? Anyway, I will only focus on NSI part for this PR and if we need to rename censusutil I will create another issue since it also is related to sample notebook as well.

[longshuicy]

One thing I noticed is there are projections crs='EPSG:4326' coded in various functions. Wondering if we can put this into a variable in a central place and refer to that in the code.

[ywkim312]

One thing I noticed is there are projections crs='EPSG:4326' coded in various functions. Wondering if we can put this into a variable in a central place and refer to that in the code.

This probably needs to be an independant issue after this get merged. At this moment, IN-CORE only uses 4326 but I was awaring of this issue and was thinking of adding the way of handling this but as you probably know, dealing with crs is much more complicated, only making it as variable might caused some other failure

[navarroc]

The test folder does not need an __init__.py file. If you remove them from the "tests" folder and the "pyincore_data" folder everything should run fine. It looks like the top level one was added but not needed at some point and wasn't caught.

[ywkim312]

The test folder does not need an __init__.py file. If you remove them from the "tests" folder and the "pyincore_data" folder everything should run fine. It looks like the top level one was added but not needed at some point and wasn't caught.

Got it so it is either to have the perfect init or just remove all in the tests. I updated the init.py in my previous push and it worked and this time I removed all of them in the tests folder and it worked. I will keep it as not having them in tests folder