Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linktypes: Add a period at the end of the first Contributors sentence #179

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

fxlb
Copy link
Contributor

@fxlb fxlb commented Jan 12, 2025

No description provided.

@guyharris
Copy link
Collaborator

That's a sentence, hence the period at the end.

@fxlb fxlb changed the title linktypes: Add a period at the end of the first Contributors paragraph linktypes: Add a period at the end of the first Contributors sentence Jan 12, 2025
@fxlb
Copy link
Contributor Author

fxlb commented Jan 13, 2025

Maybe I've misunderstood. There aren't two sentences?

  1. PCAP has been developed [...]and Jun-ichiro itojun Hagino

  2. PCAP was originally created at LBL by Steve McCanne, Craig Leres, and Van Jacobson.

@guyharris
Copy link
Collaborator

"PCAP has been developed [...]and Jun-ichiro itojun Hagino" is not a proper sentence, as there's no end-of-sentence period. "PCAP has been developed [...]and Jun-ichiro itojun Hagino." is a proper sentence.

@guyharris
Copy link
Collaborator

Sorry, I misread the change.

@guyharris guyharris merged commit 8683397 into IETF-OPSAWG-WG:master Jan 13, 2025
1 check failed
@fxlb fxlb deleted the pcaplinktype branch January 13, 2025 09:29
@fxlb
Copy link
Contributor Author

fxlb commented Jan 13, 2025

No problem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants