Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat)Add missing translations to createpatientform #593

Closed
wants to merge 17 commits into from
Closed

(feat)Add missing translations to createpatientform #593

wants to merge 17 commits into from

Conversation

jona42-ui
Copy link
Contributor

added some translations to the create patient form

@jona42-ui jona42-ui changed the title (2.8)Add missing translations to createpatientform (feat)Add missing translations to createpatientform Nov 13, 2023
@jona42-ui
Copy link
Contributor Author

@mozzy11 kindly I will need your feeedback here such that I am sure to tackle all components
Thanks

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 15, 2023

Thanks @jona42-ui .
you would avoid too many formating changes for easy review

@jona42-ui
Copy link
Contributor Author

jona42-ui commented Nov 15, 2023

Ooops! looking at my editor setting its like I set prettier as default formarter on save
how can I go about this?

@jona42-ui
Copy link
Contributor Author

or do we have specific formatting settings
sorry if I missed it

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 15, 2023

we have eslint for the frontend

but for easy review ignore the formating changes.

@jona42-ui
Copy link
Contributor Author

jona42-ui commented Nov 15, 2023

ooh so i have to revert changes

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 15, 2023

yeah , you need to revert the formating changes.

@jona42-ui
Copy link
Contributor Author

wondering how, any quick hack pliz?

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 15, 2023

you can create a fresh PR if that would consume much time

@jona42-ui jona42-ui closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants