-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed adminpage margin and made it responsive #1365 #1391
Fixed adminpage margin and made it responsive #1365 #1391
Conversation
hello @rahulkundu1209 , you can attach a video recording as well |
@Bahati308 thanks for your suggestion. I have modified the PR with a video explanation. Please have a look. |
Thanks @rahulkundu1209 . |
@mozzy11 nice to hear it from you. I have explained both before and after my changies in the video of this PR. If it is still not clear please let me know, I will be more than happy to explain it once more. |
@rahulkundu1209 in your video in the end i see that the screen is not responsive to smaller screen |
@mozzy11 @vsvishalsharma I am really sorry for that ambiguity at the end of the video. So, here I have attached two sccreenshots. In the first image which is of before change, some part of the page content is hidden under the sidebar. Whereas in the second image, the whole content is clearly visible which should be the desired behaviour I think. |
Thanks @rahulkundu1209 . |
Summary
Screenshots
AdminPage.Margin.Changed.mp4
Error version and resolved version both are explained in this video.
Related Issue
#1365