Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed adminpage margin and made it responsive #1365 #1391

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

rahulkundu1209
Copy link
Contributor

@rahulkundu1209 rahulkundu1209 commented Jan 10, 2025

Summary

  • Added responsive margin to admin page content
  • Some part of the admin page content does not hide now

Screenshots

AdminPage.Margin.Changed.mp4

Error version and resolved version both are explained in this video.

Related Issue

#1365

@rahulkundu1209 rahulkundu1209 marked this pull request as ready for review January 10, 2025 17:09
@Bahati308
Copy link
Contributor

hello @rahulkundu1209 , you can attach a video recording as well

@rahulkundu1209
Copy link
Contributor Author

rahulkundu1209 commented Jan 12, 2025

@Bahati308 thanks for your suggestion. I have modified the PR with a video explanation. Please have a look.

@mozzy11
Copy link
Collaborator

mozzy11 commented Jan 17, 2025

Thanks @rahulkundu1209 .
Can you attach screenhots of before and after your changes pointing out what changed ??

@rahulkundu1209
Copy link
Contributor Author

@mozzy11 nice to hear it from you. I have explained both before and after my changies in the video of this PR. If it is still not clear please let me know, I will be more than happy to explain it once more.

@vsvishalsharma
Copy link
Contributor

@rahulkundu1209 in your video in the end i see that the screen is not responsive to smaller screen
If possible try sharing the screenshots for better reference

@rahulkundu1209
Copy link
Contributor Author

@mozzy11 @vsvishalsharma I am really sorry for that ambiguity at the end of the video. So, here I have attached two sccreenshots. In the first image which is of before change, some part of the page content is hidden under the sidebar. Whereas in the second image, the whole content is clearly visible which should be the desired behaviour I think.

Before Change
image

After Change
image

@mozzy11
Copy link
Collaborator

mozzy11 commented Jan 20, 2025

Thanks @rahulkundu1209 .

@mozzy11 mozzy11 merged commit 5ba53ea into I-TECH-UW:develop Jan 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants