-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trim whitespace from password field during login validation #1386
Conversation
@mozzy11 can you please review this pull request? |
would like to contribute on it |
Well done @harshitg927. Now format your code correctly with the |
@Lemeri123 I have formated the code using npm run format... please review. |
Well done for solving the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @harshitg927, thanks for the work, just a few changes and you will be there. The frontend/cypress/pages/ModifyOrderPage.js file is not responsible for login validation.
@Bahati308 That's true, but these changes are a result of me running npm run format, should I still revert them? |
Yeah Kindly revert them if you haven't intended to do these changes |
c38279e
to
a611910
Compare
@vsvishalsharma done |
@CalebSLane is it fine to trim the login passowrd ?? |
Hey @CalebSLane, are there any updates for this Pull Request? Thank You. |
Thanks @harshitg927 . |
fixes issue#1382
Summary
Currently, users cannot log in when their passwords contain leading or trailing whitespace characters. This is causing failed login attempts even with correct passwords. The fix implements password string trimming during validation to allow successful authentication by removing unintentional spaces.
Changes
Screen-recording
Screencast.from.09-01-25.21.42.13.webm
Related Issue
#1385