Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the In Progress Filter to Pathology Dashboard and Cytology Dashboard #1369

Merged
merged 16 commits into from
Jan 17, 2025

Conversation

vsvishalsharma
Copy link
Contributor

@vsvishalsharma vsvishalsharma commented Jan 4, 2025

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Changed the setStatusfilter function to setup the In Progress filter with the following

statuses: [
        {id: 'GROSSING'},
        {id: 'CUTTING'},
        {id: 'PROCESSING'},
        {id: 'SLICING'},
        {id: 'STAINING'}
      ]

Screenshots

Screenshot from 2025-01-03 21-43-32

#1370 OGC 16

To DO:

  • Add the filter to Cytology

Copy link
Contributor

@Bahati308 Bahati308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not advisable to remove the value field unless there is a plan to handle display names for statuses differently, as it is critical for presenting user-friendly names in the UI.

@Bahati308
Copy link
Contributor

And also try to run the cd frontend then npm run format to format the changes

@vsvishalsharma
Copy link
Contributor Author

And also try to run the cd frontend then npm run format to format the changes

Hey thanks for mentioning but I ran it already

@vsvishalsharma
Copy link
Contributor Author

vsvishalsharma commented Jan 5, 2025

It is not advisable to remove the value field unless there is a plan to handle display names for statuses differently, as it is critical for presenting user-friendly names in the UI.

Will do the changes

@vsvishalsharma
Copy link
Contributor Author

Hi @mozzy11,

I’d love to hear your feedback on this when you get a chance. Let me know if there’s anything I can improve or adjust!

@mozzy11
Copy link
Collaborator

mozzy11 commented Jan 16, 2025

Thanks @vsvishalsharma .
Was there a reason you added the QUALITY_CONTROL for Cytology status. ?

@vsvishalsharma
Copy link
Contributor Author

Screenshot from 2025-01-17 13-11-51

@mozzy11 I have removed the hardcode statuses

@mozzy11 mozzy11 merged commit ae2166c into I-TECH-UW:develop Jan 17, 2025
4 checks passed
@mozzy11
Copy link
Collaborator

mozzy11 commented Jan 17, 2025

Great job @vsvishalsharma

@vsvishalsharma vsvishalsharma deleted the Add_Filter branch January 17, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants