Support unmapped adjacency list indices antoinerg#14

HusseinElMotayam · Mar 11, 2020 · 9fda2c0 · 9fda2c0
1 parent deb7762
commit 9fda2c0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/johnson.js b/johnson.js
@@ -70,7 +70,7 @@ module.exports = function findCircuits(edges, cb) {
     function subgraph(minId) {
       // Remove edges with indice smaller than minId
         for(var i = 0; i < edges.length; i++) {
-            if(i < minId) edges[i] = [];
+            if(i < minId || !edges[i]) edges[i] = [];
             edges[i] = edges[i].filter(function(i) {
                 return i >= minId;
             });

diff --git a/test/test.js b/test/test.js
@@ -43,6 +43,25 @@ test('find elementarty circuits in', function(t) {
         t.end();
     });
 
+    t.test('another simple directed graph with orphaned nodes', function(t) {
+    //       V4      V2
+    // +-<---o---<---o
+    // |             |
+    // o V0          ^      o V3
+    // |           V1|
+    // +------>------o
+        var g = [];
+        g[0] = [1];
+        g[1] = [2];
+    // g[3] is unmapped
+        g[2] = [4];
+        g[4] = [0];
+
+        var circuits = findCircuits(g);
+        t.deepEqual(circuits, [[0, 1, 2, 4, 0]]);
+        t.end();
+    });
+
     t.test('another simple directed graph with callback', function(t) {
         var g = [
           [1],