Bugfix in setup.py: don't break when nvidia-smi does not exist (opena…

…i#240)
HumanCompatibleAI · Mar 22, 2019 · 76e6d2f · 76e6d2f
1 parent 06f5843
commit 76e6d2f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/docs/misc/changelog.rst b/docs/misc/changelog.rst
@@ -13,6 +13,7 @@ Pre-release 2.4.2a (WIP)
 - fixed bug in saving and loading ddpg model when using normalization of obs or returns (@tperol)
 - changed DDPG default buffer size from 100 to 50000.
 - fixed a bug in ``ddpg.py`` in ``combined_stats`` for eval. Computed mean on ``eval_episode_rewards`` and ``eval_qs``
+- fixed a bug in ``setup.py`` that would error on non-GPU systems without TensorFlow installed
 
 
 Release 2.4.1 (2019-02-11)

diff --git a/setup.py b/setup.py
@@ -20,9 +20,12 @@
     install_tf = True
     # Check if a nvidia gpu is present
     for command in ['nvidia-smi', '/usr/bin/nvidia-smi', 'nvidia-smi.exe']:
-        if subprocess.call([command]) == 0:
-            tf_gpu = True
-            break
+        try:
+            if subprocess.call([command]) == 0:
+                tf_gpu = True
+                break
+        except IOError:  # command does not exist / is not executable
+            pass
 
 tf_dependency = []
 if install_tf: