Unwrap maps when serializing #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately I can't find a way to say "if this serializes to a json object, do that and add @Result" |
|
It seems pretty reasonable to me, but eyeballing jackson is always a pain |
|
Yeah, that's why the tests are so so important. I mainly wonder if there are any other types that should be flattened. Table? |
|
Well, table deserialization is not currently supported: FasterXML/jackson-datatypes-collections#1, but I feel like supporting it in algebra still makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that
MapandMultimaptypes are flattened a la beans. Any objections?@zklapow @szabowexler @jhaber @kmclarnon @darcatron