catgirl 2.2a (new formula)

[andrewrothman]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[github-actions]

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

[andrewrothman]

Hi, the software I'm trying to submit supports macOS and Linux, etc. I have performed the steps mentioned for macOS, but the CI failure appears to be for Linux.

I don't see much in the CI logs, and I'm having trouble running the Homebrew Docker container on my M1 Pro MacBook Pro.

$ uname -a
Darwin REDACTED 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec  6 19:01:59 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T6000 arm64
$ docker run --interactive --tty --rm --pull always homebrew/ubuntu22.04:latest /bin/bash
docker: Error response from daemon: no matching manifest for linux/arm64/v8 in the manifest list entries: no match for platform in manifest: not found.
See 'docker run --help'.

Any advice would be appreciated.

Thanks,
Andrew

[botantony]

add missing dependencies

[botantony]

i guess you should list build dependencies in alphabetic order to have correct tap syntax

[botantony]

use uses_from_macos "ncurses" instead of depends_on "ncurses"

[botantony]

Just tried new test case on my machine and it works fine

Also I think it would be nice to include --enable-sandman flag when running config script on macOS. Something like

args = %W[
  --mandir=#{man}
]

if OS.mac?
  args << "--enable-sandman"
end

system "./configure", "--disable-silent-rules", *std_configure_args, *args
system "make"
system "make", "install"

[andrewrothman]

@ bevanjkay:

[this] may fix the failing test

It did indeed. Thanks!

@ botantony:

Also I think it would be nice to include --enable-sandman flag when running config script on macOS.

Good idea! Added.

[botantony]

can you squash your commits into one and follow the commit style (so the tests wont complain about it). i guess your commit summary should be just catgirl 2.2a (new formula) since you're adding a new formula

[andrewrothman]

OK - squashed my commits w/ commit style.

[nandahkrishna]

Suggested change

	license "GPL-3.0-or-later"
	depends_on "ctags" => :build
	license "GPL-3.0-or-later"
	livecheck do
	url "https://git.causal.agency/catgirl"
	regex(/href=.*?catgirl[._-]v?(\d+(?:\.\d+)+[a-z]?)\.t/i)
	end
	depends_on "ctags" => :build

We need an explicit livecheck block as brew livecheck isn't able to fetch versions without one. The Git strategy doesn't seem to work so we can go with this, at least for now.