Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby*: fix postinstall #179335

Merged
merged 4 commits into from
Aug 1, 2024
Merged

ruby*: fix postinstall #179335

merged 4 commits into from
Aug 1, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Aug 1, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

similar to #179332

@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 1, 2024
@github-actions github-actions bot added the legacy Relates to a versioned @ formula label Aug 1, 2024
@chenrui333 chenrui333 changed the title Ruby fixes ruby*: fix postinstall Aug 1, 2024
@chenrui333 chenrui333 mentioned this pull request Aug 1, 2024
Merged
6 tasks
@Homebrew Homebrew deleted a comment from github-actions bot Aug 1, 2024
issyl0
issyl0 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - apologies again!

@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit 7b50c32 Aug 1, 2024
18 checks passed
@BrewTestBot BrewTestBot deleted the ruby-fixes branch August 1, 2024 23:12
@chenrui333
Copy link
Member Author

Thanks - apologies again!

no worries at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@issyl0 issyl0 issyl0 approved these changes

Assignees
No one assigned
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. legacy Relates to a versioned @ formula
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @issyl0 @scpeters @BrewTestBot