audit: run syntax check for new formulae earlier

[iMichka]

This will run the notability check earlier, so that maintainers don't spend time fixing other syntax issues that are only checked later by test bot.

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[iMichka]

This is an early draft:

• Not sure if this is the best place to add this, as we are starting to add unrelated stuff to the formulae_detect step. But we can still split this up in a second pass?
• Not sure if we want to tweak test bot to not redo the audit again later?

[stefanb]

Shouldn't it be also removed from later tests?

[MikeMcQuaid]

• Not sure if this is the best place to add this, as we are starting to add unrelated stuff to the formulae_detect step. But we can still split this up in a second pass?

Instead I would add this to the tap_syntax step which is run earlier and is quicker to run. Think you'll need an --online for this, too, and probably should put it in brew test-bot instead.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.