Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add analytics report to CI #177405

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

SMillerDev
Copy link
Member

@SMillerDev SMillerDev commented Jul 15, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This will eventually allow us to see how often a formula is installed, to grasp how much effort is warranted to fix it.

@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Jul 15, 2024
@SMillerDev SMillerDev force-pushed the feat/ci/report_formula_stats branch 10 times, most recently from 58ea92d to d4fdf27 Compare July 15, 2024 18:58
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still draft?

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@SMillerDev SMillerDev marked this pull request as ready for review July 16, 2024 12:57
@SMillerDev SMillerDev requested review from MikeMcQuaid and a team as code owners July 16, 2024 12:57
.github/workflows/tests.yml Show resolved Hide resolved
@SMillerDev SMillerDev enabled auto-merge July 16, 2024 22:29
@SMillerDev SMillerDev added this pull request to the merge queue Jul 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Jul 16, 2024
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@carlocab carlocab force-pushed the feat/ci/report_formula_stats branch from 3cada4f to 99e01c0 Compare July 17, 2024 11:56
@carlocab carlocab enabled auto-merge July 17, 2024 11:56
@carlocab carlocab added this pull request to the merge queue Jul 17, 2024
Merged via the queue into master with commit 3759d47 Jul 17, 2024
18 checks passed
@carlocab carlocab deleted the feat/ci/report_formula_stats branch July 17, 2024 12:05
exit 0
fi

{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could probably all be replaced with brew info --analytics $TESTING_FORMULAE?

Copy link
Member Author

@SMillerDev SMillerDev Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but that immediately puts it in tables that aren't as much more verbose than this one. And brew info --json doesn't seem to have that data.

EDIT: example:
==> Analytics
==> install (30 days)

Index Name (with options) Count Percent
1 hello 2,106 100.00%
==> install (90 days)
Index Name (with options) Count Percent
-----: --------------------------------------------------------------------------------------------------------------------------------------------- ------: --------:
1 hello 6,515 100.00%
==> install (365 days)
Index Name (with options) Count Percent
-----: -------------------------------------------------------------------------------------------------------------------------------------------- -------: --------:
1 hello 25,080 99.97%
2 hello --HEAD 7 0.03%
Total 25,087 100.00%
==> install-on-request (30 days)
Index Name (with options) Count Percent
-----: --------------------------------------------------------------------------------------------------------------------------------------------- ------: --------:
1 hello 2,104 100.00%
==> install-on-request (90 days)
Index Name (with options) Count Percent
-----: --------------------------------------------------------------------------------------------------------------------------------------------- ------: --------:
1 hello 6,513 100.00%
==> install-on-request (365 days)
Index Name (with options) Count Percent
-----: -------------------------------------------------------------------------------------------------------------------------------------------- -------: --------:
1 hello 25,078 99.97%
2 hello --HEAD 7 0.03%
Total 25,085 100.00%
==> build-error (30 days)
Index Name (with options) Count Percent
-----: --------------------------------------------------------------------------------------------------------------------------------------------- ------: --------:
1 hello 16 100.00%

==> Analytics
==> install (30 days)

Index Name (with options) Count Percent
1 beanstalkd 36 100.00%
==> install (90 days)
Index Name (with options) Count Percent
-----: --------------------------------------------------------------------------------------------------------------------------------------------- ------: --------:
1 beanstalkd 371 99.73%
2 beanstalkd --HEAD 1 0.27%
Total 372 100.00%
==> install (365 days)
Index Name (with options) Count Percent
-----: --------------------------------------------------------------------------------------------------------------------------------------------- ------: --------:
1 beanstalkd 793 99.75%
2 beanstalkd --HEAD 2 0.25%
Total 795 100.00%
==> install-on-request (30 days)
Index Name (with options) Count Percent
-----: --------------------------------------------------------------------------------------------------------------------------------------------- ------: --------:
1 beanstalkd 35 100.00%
==> install-on-request (90 days)
Index Name (with options) Count Percent
-----: --------------------------------------------------------------------------------------------------------------------------------------------- ------: --------:
1 beanstalkd 365 99.73%
2 beanstalkd --HEAD 1 0.27%
Total 366 100.00%
==> install-on-request (365 days)
Index Name (with options) Count Percent
-----: --------------------------------------------------------------------------------------------------------------------------------------------- ------: --------:
1 beanstalkd 772 99.74%
2 beanstalkd --HEAD 2 0.26%
Total 774 100.00%
==> build-error (30 days)
Index Name (with options) Count Percent
-----: --------------------------------------------------------------------------------------------------------------------------------------------- ------: --------:
1 beanstalkd 0 0.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants