Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-matplotlib 3.8.2 (new formula) #154736

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

singingwolfboy
Copy link
Member

@singingwolfboy singingwolfboy commented Nov 18, 2023

matplotlib is a popular package within the scientific Python community. All of its dependencies are packaged in Homebrew except for Contourpy (see #154705), which is included as a resource instead.

Depends on #154801 in order to use the --no-isolation flag to python-build, which in turn allows us to use the Homebrew-installed build dependencies, instead of python-build downloading and installing them during the build process.

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Nov 18, 2023
@singingwolfboy singingwolfboy force-pushed the matplotlib branch 4 times, most recently from bbf6b78 to f4ea951 Compare November 18, 2023 10:22
@cho-m
Copy link
Member

cho-m commented Nov 18, 2023

matplotlib will vendor a couple dependencies without some extra workarounds (see #154454 though don't need MPLSETUPCFG env var when already inside the source root as that is default).

Current release needs mplsetup.cfg to use Homebrew copies - https://github.com/matplotlib/matplotlib/blob/v3.8.2/doc/devel/dependencies.rst#use-system-libraries

Future release will need to be passed in as arguments to pip - https://github.com/matplotlib/matplotlib/blob/main/doc/devel/dependencies.rst#use-system-libraries

@singingwolfboy singingwolfboy force-pushed the matplotlib branch 7 times, most recently from 1b29f76 to 940b0b4 Compare November 19, 2023 17:09
Formula/p/python-matplotlib.rb Outdated Show resolved Hide resolved
Formula/p/python-matplotlib.rb Show resolved Hide resolved
Formula/p/python-matplotlib.rb Show resolved Hide resolved
Formula/p/python-matplotlib.rb Outdated Show resolved Hide resolved
Formula/p/python-matplotlib.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 19, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 19, 2023
Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done!

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 20, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 20, 2023
Merged via the queue into Homebrew:master with commit adfc485 Nov 20, 2023
12 checks passed
@chenrui333
Copy link
Member

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants