Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dosbox sdl_net sdl_sound: deprecate #123161

Closed
wants to merge 3 commits into from
Closed

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 14, 2023

Relates to #106902. Checking for feedback as dosbox does have some installs and upstream activity.


Copying comment I wrote in issue below:

I wonder if we should just deprecate dosbox formula.

We still have a Cask for macOS users - https://formulae.brew.sh/cask/dosbox#default

And SDL2 supported forks:

Only issue is the dosbox formula is still somewhat popular:

==> Analytics
install: 342 (30 days), 1,226 (90 days), 4,280 (365 days)
install-on-request: 359 (30 days), 1,241 (90 days), 4,291 (365 days)
build-error: 0 (30 days)

Though a deprecation message with recommended alternatives could help steer some users away.


Fedora is an example repository that dropped support for dosbox and recommend dosbox-staging to its users - https://src.fedoraproject.org/rpms/dosbox

@cho-m cho-m added do not merge maintainer feedback Additional maintainers' opinions may be needed labels Feb 14, 2023
@BrewTestBot BrewTestBot added the formula deprecated Formula deprecated label Feb 14, 2023
@cho-m cho-m mentioned this pull request Feb 14, 2023
22 tasks
Copy link
Member

@iMichka iMichka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the dosbox-deprecate branch February 14, 2023 19:15
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
formula deprecated Formula deprecated maintainer feedback Additional maintainers' opinions may be needed outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants