Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc@5 gcc@6 [email protected]: deprecate #110163

Closed
wants to merge 3 commits into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 9, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Need confirmation if safe to deprecate gcc@5 now, which is needed to re-deprecate [email protected] (related to #106902).

Also considering deprecating gcc@6 to reduce number of GCC formulae to get closer to our versioning requirement. GCC 6 seems to be least used of not-yet-deprecated but officially unsupported/unmaintained GCC versions (GCC 9 and older are no longer supported -- https://gcc.gnu.org/gcc-9/)

GCC formulae does still exceed our max of 5 versions by 1 (i.e. 7, 8, 9, 10, 11, unversioned/12).

@cho-m cho-m added maintainer feedback Additional maintainers' opinions may be needed CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Sep 9, 2022
@BrewTestBot BrewTestBot added formula deprecated Formula deprecated legacy Relates to a versioned @ formula labels Sep 9, 2022
@cho-m cho-m mentioned this pull request Sep 9, 2022
22 tasks
@cho-m cho-m removed the maintainer feedback Additional maintainers' opinions may be needed label Sep 9, 2022
@Bo98
Copy link
Member

Bo98 commented Sep 9, 2022

It might be worth seeing the gcc@5 install count go down first.

In the meantime, it may be worth considering what we should continue to support as a compiler in brew: https://github.com/Homebrew/brew/blob/24153391249a51b3de14a2b92f8d84707f538882/Library/Homebrew/compilers.rb#L6

@danielnachun
Copy link
Member

GCC formulae does still exceed our max of 5 versions by 1 (i.e. 7, 8, 9, 10, 11, unversioned/12).

GCC 7 will not build on Ubuntu 22.04 without patching, so we should also deprecate it. Conveniently, that would get us down to only 5 versions.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux installs for gcc@5 in the past 30 days are only 3% of installs in the past year, so installs are already on the way down. Let's help that along with a deprecation.

We can postpone disabling if there are still too many installs.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the gcc-deprecate branch September 10, 2022 15:44
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated legacy Relates to a versioned @ formula outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants