-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcc@5 gcc@6 [email protected]: deprecate #110163
Conversation
It might be worth seeing the In the meantime, it may be worth considering what we should continue to support as a compiler in brew: https://github.com/Homebrew/brew/blob/24153391249a51b3de14a2b92f8d84707f538882/Library/Homebrew/compilers.rb#L6 |
GCC 7 will not build on Ubuntu 22.04 without patching, so we should also deprecate it. Conveniently, that would get us down to only 5 versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux installs for gcc@5
in the past 30 days are only 3% of installs in the past year, so installs are already on the way down. Let's help that along with a deprecation.
We can postpone disabling if there are still too many installs.
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Need confirmation if safe to deprecate
gcc@5
now, which is needed to re-deprecate[email protected]
(related to #106902).Also considering deprecating
gcc@6
to reduce number of GCC formulae to get closer to our versioning requirement. GCC 6 seems to be least used of not-yet-deprecated but officially unsupported/unmaintained GCC versions (GCC 9 and older are no longer supported -- https://gcc.gnu.org/gcc-9/)GCC formulae does still exceed our max of 5 versions by 1 (i.e. 7, 8, 9, 10, 11, unversioned/12).