Merge pull request #179322 from Homebrew/x-interpolated-bin-audit

x*: Stop interpolating `bin`

Formula/x/xa.rb

@@ -30,7 +30,7 @@ def install
   test do
     (testpath/"foo.a").write "jsr $ffd2\n"
 
-    system "#{bin}/xa", "foo.a"
+    system bin/"xa", "foo.a"
     code = File.open("a.o65", "rb") { |f| f.read.unpack("C*") }
     assert_equal [0x20, 0xd2, 0xff], code
   end

Formula/x/xaric.rb

@@ -49,7 +49,7 @@ def install
   test do
     require "pty"
     output = ""
-    PTY.spawn("#{bin}/xaric", "-v") do |r, _w, _pid|
+    PTY.spawn(bin/"xaric", "-v") do |r, _w, _pid|
       r.each_line { |line| output += line }
     rescue Errno::EIO
       # GNU/Linux raises EIO when read is done on closed pty

Formula/x/xclip.rb

@@ -33,6 +33,6 @@ def install
   end
 
   test do
-    system "#{bin}/xclip", "-version"
+    system bin/"xclip", "-version"
   end
 end

Formula/x/xcode-build-server.rb

@@ -24,6 +24,6 @@ def install
   end
 
   test do
-    system "#{bin}/xcode-build-server", "--help"
+    system bin/"xcode-build-server", "--help"
   end
 end

Formula/x/xcproj.rb

@@ -52,6 +52,6 @@ def caveats
   end
 
   test do
-    system "#{bin}/xcproj", "--version"
+    system bin/"xcproj", "--version"
   end
 end

Formula/x/xcv.rb

@@ -14,6 +14,6 @@ def install
   end
 
   test do
-    system "#{bin}/xcv"
+    system bin/"xcv"
   end
 end

Formula/x/xdotool.rb

@@ -51,6 +51,6 @@ def caveats
   end
 
   test do
-    system "#{bin}/xdotool", "--version"
+    system bin/"xdotool", "--version"
   end
 end

Formula/x/xhyve.rb

@@ -32,6 +32,6 @@ def install
   end
 
   test do
-    system "#{bin}/xhyve", "-v"
+    system bin/"xhyve", "-v"
   end
 end

Formula/x/xml2.rb

@@ -35,6 +35,6 @@ def install
   end
 
   test do
-    assert_equal "/test", pipe_output("#{bin}/xml2", "<test/>", 0).chomp
+    assert_equal "/test", pipe_output(bin/"xml2", "<test/>", 0).chomp
   end
 end

Formula/x/xmlcatmgr.rb

@@ -29,6 +29,6 @@ def install
   end
 
   test do
-    system "#{bin}/xmlcatmgr", "-v"
+    system bin/"xmlcatmgr", "-v"
   end
 end

Formula/x/xmlformat.rb

@@ -17,6 +17,6 @@ def install
   end
 
   test do
-    system "#{bin}/xmlformat", "--version"
+    system bin/"xmlformat", "--version"
   end
 end

Formula/x/xmlrpc-c.rb

@@ -36,6 +36,6 @@ def install
   end
 
   test do
-    system "#{bin}/xmlrpc-c-config", "--features"
+    system bin/"xmlrpc-c-config", "--features"
   end
 end

Formula/x/xmlsectool.rb

@@ -24,6 +24,6 @@ def install
   end
 
   test do
-    system "#{bin}/xmlsectool", "--listAlgorithms"
+    system bin/"xmlsectool", "--listAlgorithms"
   end
 end

Formula/x/xmlstarlet.rb

@@ -34,6 +34,6 @@ def install
   end
 
   test do
-    system "#{bin}/xmlstarlet", "--version"
+    system bin/"xmlstarlet", "--version"
   end
 end

Formula/x/xplanet.rb

@@ -80,13 +80,13 @@ def install
 
   # Test all the supported image formats, jpg, png, gif and tiff, as well as the -num_times 2 patch
   test do
-    system "#{bin}/xplanet", "-target", "earth", "-output", "#{testpath}/test.jpg",
-                             "-radius", "30", "-num_times", "2", "-random", "-wait", "1"
-    system "#{bin}/xplanet", "-target", "earth", "--transpng", "#{testpath}/test.png",
-                             "-radius", "30", "-num_times", "2", "-random", "-wait", "1"
-    system "#{bin}/xplanet", "-target", "earth", "--output", "#{testpath}/test.gif",
-                             "-radius", "30", "-num_times", "2", "-random", "-wait", "1"
-    system "#{bin}/xplanet", "-target", "earth", "--output", "#{testpath}/test.tiff",
-                             "-radius", "30", "-num_times", "2", "-random", "-wait", "1"
+    system bin/"xplanet", "-target", "earth", "-output", "#{testpath}/test.jpg",
+                          "-radius", "30", "-num_times", "2", "-random", "-wait", "1"
+    system bin/"xplanet", "-target", "earth", "--transpng", "#{testpath}/test.png",
+                          "-radius", "30", "-num_times", "2", "-random", "-wait", "1"
+    system bin/"xplanet", "-target", "earth", "--output", "#{testpath}/test.gif",
+                          "-radius", "30", "-num_times", "2", "-random", "-wait", "1"
+    system bin/"xplanet", "-target", "earth", "--output", "#{testpath}/test.tiff",
+                          "-radius", "30", "-num_times", "2", "-random", "-wait", "1"
   end
 end

Formula/x/xrootd.rb

@@ -66,7 +66,7 @@ def install
   end
 
   test do
-    system "#{bin}/xrootd", "-H"
+    system bin/"xrootd", "-H"
     system "python3.12", "-c", <<~EOS
       import XRootD
       from XRootD import client

Formula/x/xsane.rb

@@ -47,6 +47,6 @@ def install
     # (xsane:27015): Gtk-WARNING **: 12:58:53.105: cannot open display
     return if OS.linux? && ENV["HOMEBREW_GITHUB_ACTIONS"]
 
-    system "#{bin}/xsane", "--version"
+    system bin/"xsane", "--version"
   end
 end

Formula/x/xsd.rb

@@ -82,7 +82,7 @@ def install
           return 0;
       }
     EOS
-    system "#{bin}/xsd", "cxx-tree", schema
+    system bin/"xsd", "cxx-tree", schema
     assert_predicate testpath/"meaningoflife.hxx", :exist?
     assert_predicate testpath/"meaningoflife.cxx", :exist?
     system ENV.cxx, "-o", "xsdtest", "xsdtest.cxx", "meaningoflife.cxx", "-std=c++11",

Formula/x/xurls.rb

@@ -25,7 +25,7 @@ def install
   end
 
   test do
-    output = pipe_output("#{bin}/xurls", "Brew test with https://brew.sh.")
+    output = pipe_output(bin/"xurls", "Brew test with https://brew.sh.")
     assert_equal "https://brew.sh", output.chomp
 
     output = pipe_output("#{bin}/xurls --fix", "Brew test with http://brew.sh.")

Formula/x/xxh.rb

@@ -58,7 +58,7 @@ def install
       end
 
       stdout, stderr, = Open3.capture3(
-        "#{bin}/xxh", "test.localhost",
+        bin/"xxh", "test.localhost",
         "-p", port.to_s,
         "+xc", "#{testpath}/config.xxhc",
         "+v"