Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go 1.8 #31728

Closed
wants to merge 1 commit into from
Closed

Add go 1.8 #31728

wants to merge 1 commit into from

Conversation

chulkilee
Copy link
Contributor

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

Note that brew cask uninstall go does not remove /usr/local/go. Should it remove that directory?

@vitorgalvao
Copy link
Member

Thank you, but this is a language, so it belongs in Homebrew.

Additionally, pkg casks require an uninstall to be accepted.

@chulkilee
Copy link
Contributor Author

I know brew has it (https://github.com/Homebrew/homebrew-core/blob/master/Formula/go.rb) but it compiles (or uses bottle for custom build, I guess), not using the official package installer. I believe they have their own merits - so why can't we have go in both brew and brew cask?

Note that go from brew cask can "coexist" with go from brew, since it installs binaries on /usr/local/go/bin while brew version installs binaries to /usr/local/bin

Added uninstall stanza - now uninstall works.

@vitorgalvao
Copy link
Member

so why can't we have go in both brew and brew cask?

#15603

Because it took a lot of people time to reduce duplicated efforts between the projects, and we don’t want to undo that.

@chulkilee
Copy link
Contributor Author

Thanks for the link! I ended up with https://github.com/chulkilee/homebrew-alt

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants