Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ui development target #93

Merged
merged 6 commits into from
Sep 29, 2024

Conversation

Emnaghz
Copy link
Collaborator

@Emnaghz Emnaghz commented Sep 27, 2024

Motivation

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (Storybook)
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Emnaghz for your contribution 🙏

Left some comments !

frontend/Dockerfile Outdated Show resolved Hide resolved
frontend/next.config.mjs Outdated Show resolved Hide resolved
docker/docker-compose.dev.yml Outdated Show resolved Hide resolved
@yassine-sallemi yassine-sallemi changed the title fix: draft-add ui development target fix: add ui development target Sep 27, 2024
Copy link
Collaborator

@yassinedorbozgithub yassinedorbozgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

frontend/next.config.mjs Outdated Show resolved Hide resolved
@marrouchi
Copy link
Contributor

marrouchi commented Sep 29, 2024

Thanks @Emnaghz Looks perfect ! 👏

@marrouchi marrouchi merged commit 604dd5a into Hexastack:main Sep 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants