Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error handling for invalid URL submission #73

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

devamitranjan
Copy link
Contributor

@devamitranjan devamitranjan commented Sep 23, 2024

Motivation

Added the URL regex to ensure the validation before submitting the data.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (Storybook)
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@devamitranjan
Copy link
Contributor Author

Screencast.from.24-09-24.02.13.58.AM.IST.webm

@Emnaghz
Copy link
Collaborator

Emnaghz commented Sep 23, 2024

Thank you @devamitranjan for your contribution 🎉 🥳 🚀

Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @devamitranjan 👏

@marrouchi marrouchi merged commit 3110c6a into Hexastack:main Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - Persistent Menu: Improve Error Handling for Invalid URL Submission
3 participants