Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cors issue #623

Merged
merged 5 commits into from
Jan 24, 2025
Merged

fix: cors issue #623

merged 5 commits into from
Jan 24, 2025

Conversation

abdou6666
Copy link
Member

@abdou6666 abdou6666 commented Jan 23, 2025

Motivation

This PR addresses the issue of CORS not being dynamic E.g : user updates settings of allowed origins of a channel but they don't take effect unless user changes them through env variable & then re-starts application

Fixes # (issue)

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@marrouchi marrouchi merged commit 26c9470 into main Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - CORS Configuration Ignores User-Defined Domains for the Web Chat Widget
2 participants