Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update block plugin settings visibility #618

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

MohamedAliBouhaouala
Copy link
Contributor

@MohamedAliBouhaouala MohamedAliBouhaouala commented Jan 22, 2025

Motivation

The following PR updates block settings visibility to private in order to avoid confusion between default block settings and block args.

Fixes # (598)

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@MohamedAliBouhaouala MohamedAliBouhaouala changed the title feat: fix unit test feat: update block plugin settings visibility Jan 22, 2025
@MohamedAliBouhaouala MohamedAliBouhaouala requested review from marrouchi, medchedli and abdou6666 and removed request for marrouchi and medchedli January 22, 2025 17:15
@marrouchi marrouchi merged commit 44cd2e7 into main Jan 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants