Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary state change #605

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

IkbelTalebHssan
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan commented Jan 22, 2025

Motivation

React's focus behavior can be affected when a component re-renders due to state changes. In this case, updating the local password state caused the PasswordInput component to re-render unnecessarily. This re-render could interfere with the input field's focus.

Fixes #593

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@IkbelTalebHssan IkbelTalebHssan marked this pull request as ready for review January 22, 2025 14:33
@marrouchi marrouchi requested review from Emnaghz and removed request for marrouchi January 23, 2025 10:16
Copy link
Collaborator

@Emnaghz Emnaghz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marrouchi marrouchi merged commit 6ff6c5a into main Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when updating the user account password
4 participants