fix: logout #604
Merged
fix: logout #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| onSuccess: async () => { | ||
| queryClient.removeQueries([CURRENT_USER_KEY]); | ||
| await logoutRedirection(); | ||
| }, |
There was a problem hiding this comment.
I have this minor suggestion
Suggested change
| }, | |
| onError: (error) => { | |
| toast.error(t("message.logout_failed")); | |
| } | |
| }, |
There was a problem hiding this comment.
@IkbelTalebHssan good idea i'll address it in different PR
IkbelTalebHssan
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
LGTM 🚀
The issue is fixed like shown in the screenshots 👏
Screencast from 01-22-2025 11:04:27 AM.webm
Screencast from 01-22-2025 11:02:37 AM.webm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses the issue when users logs out, the dashboard displays for a second then page refreshes and logs out the user
Fixes #594
Type of change:
Please delete options that are not relevant.
Checklist: