Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimize docker frontend cache #602

Merged
merged 3 commits into from
Jan 23, 2025
Merged

fix: optimize docker frontend cache #602

merged 3 commits into from
Jan 23, 2025

Conversation

abdou6666
Copy link
Member

@abdou6666 abdou6666 commented Jan 21, 2025 •
edited
Loading

Motivation

This PR fixes issues related to docker not caching frontend steps

Fixes #606

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code

@abdou6666 abdou6666 mentioned this pull request Jan 22, 2025
Closed
2 tasks
marrouchi
marrouchi requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting the following issue:
image

IkbelTalebHssan
IkbelTalebHssan approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a difference between the frontend image sizes 👏
Screenshot from 2025-01-22 12-01-01
Screenshot from 2025-01-22 11-30-00
But I got this error as well
image

@IkbelTalebHssan IkbelTalebHssan self-requested a review January 22, 2025 11:17
marrouchi
marrouchi requested changes Jan 22, 2025
View reviewed changes
frontend/Dockerfile Outdated Show resolved Hide resolved
@abdou6666
Copy link
Member Author

abdou6666 commented Jan 22, 2025 •
edited
Loading

Noticed a difference between the frontend image sizes 👏 Screenshot from 2025-01-22 12-01-01 Screenshot from 2025-01-22 11-30-00 But I got this error as well image

The error you got has been addressed by this PR #601

@abdou6666 abdou6666 force-pushed the fix/optimize-docker-frontend-caching branch from b37abe8 to f139783 Compare January 22, 2025 15:36
@abdou6666 abdou6666 requested a review from marrouchi January 22, 2025 16:05
IkbelTalebHssan
IkbelTalebHssan approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue mentioned above in the comments is resolved now the frontend container is running correctly ✔️

@marrouchi marrouchi merged commit ee7c618 into main Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IkbelTalebHssan IkbelTalebHssan IkbelTalebHssan approved these changes

@marrouchi marrouchi marrouchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize Docker images build time
3 participants
@abdou6666 @marrouchi @IkbelTalebHssan