-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(api): centralize updateOne error handling logic #579
Merged
marrouchi
merged 3 commits into
main
from
576-issue---refactor-updateone-logic-to-centralize-logs
Jan 20, 2025
Merged
update(api): centralize updateOne error handling logic #579
marrouchi
merged 3 commits into
main
from
576-issue---refactor-updateone-logic-to-centralize-logs
Jan 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassinedorbozgithub
changed the title
refactor(api): Refactor updateOne logic
refactor(api): centralize updateOne logic
Jan 16, 2025
yassinedorbozgithub
changed the title
refactor(api): centralize updateOne logic
refactor(api): centralize updateOne error handling logic
Jan 17, 2025
marrouchi
requested changes
Jan 17, 2025
yassinedorbozgithub
changed the title
refactor(api): centralize updateOne error handling logic
update(api): centralize updateOne error handling logic
Jan 17, 2025
marrouchi
approved these changes
Jan 17, 2025
abdou6666
reviewed
Jan 17, 2025
* 2. All derivative works must include clear attribution to the original creator and software, Hexastack and Hexabot, in a prominent location (e.g., in the software's "About" section, documentation, and README file). | ||
*/ | ||
|
||
export const getUpdateOneError = (entity: string, id?: string) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is id
optional for the sake of tests?
abdou6666
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The main motivation of this PR is to update the code related to the updateOne methods (repository, service).
Fixes #576
Checklist: