fix: missing payload new_users events influxdb #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedAliBouhaouala
approved these changes
Jan 13, 2025
marrouchi
requested changes
Jan 22, 2025
Comment on lines
249
to
254
| this.eventEmitter.emit( | ||
| 'hook:stats:entry', | ||
| BotStatsType.new_users, | ||
| 'New users', | ||
| subscriber, | ||
| ); |
There was a problem hiding this comment.
Suggested change
| this.eventEmitter.emit( | |
| 'hook:stats:entry', | |
| BotStatsType.new_users, | |
| 'New users', | |
| subscriber, | |
| ); |
This can safely be removed cause we are already emitting an event in postCreate() : Check api/src/chat/repositories/subscriber.repository.ts
Thank you for spotting this 🙏
abdou6666
force-pushed
the
fix/missing-payload-influx-new-users-event
branch
from
1737319 to
5d1793c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a missing payload when emitting new_users event for influxdb, influxdb expects the subscriber hook:stats:entry ligne 644
Fixes #556
Type of change:
Please delete options that are not relevant.
Checklist: