Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply strict null checks updates to the Chat Module #547

Merged
merged 15 commits into from
Jan 15, 2025
Merged

fix: apply strict null checks updates to the Chat Module #547

merged 15 commits into from
Jan 15, 2025

Conversation

yassinedorbozgithub
Copy link
Collaborator

@yassinedorbozgithub yassinedorbozgithub commented Jan 9, 2025 •
edited
Loading

Motivation

The motivation of this PR is to resolve Chat Module null checks issues

Fixes #545

image

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@yassinedorbozgithub yassinedorbozgithub self-assigned this Jan 9, 2025
marrouchi
marrouchi requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the frontend typing as well.

marrouchi
marrouchi requested changes Jan 9, 2025
View reviewed changes
api/src/chat/services/bot.service.ts Outdated Show resolved Hide resolved
api/src/chat/services/bot.service.ts Outdated Show resolved Hide resolved
api/src/chat/services/context-var.service.ts Outdated Show resolved Hide resolved
api/src/chat/services/conversation.service.ts Outdated Show resolved Hide resolved
@yassinedorbozgithub yassinedorbozgithub marked this pull request as draft January 12, 2025 09:22
@yassinedorbozgithub yassinedorbozgithub marked this pull request as ready for review January 13, 2025 14:41
@yassinedorbozgithub yassinedorbozgithub changed the base branch from 540-issue-nlp-module-strictnullchecks-issues to main January 13, 2025 17:03
marrouchi
marrouchi requested changes Jan 14, 2025
View reviewed changes
api/src/chat/schemas/subscriber.schema.ts Outdated Show resolved Hide resolved
api/src/chat/schemas/subscriber.schema.ts Outdated Show resolved Hide resolved
api/src/chat/schemas/subscriber.schema.ts Outdated Show resolved Hide resolved
marrouchi
marrouchi requested changes Jan 14, 2025
View reviewed changes
api/src/utils/test/sort.ts Outdated Show resolved Hide resolved
marrouchi
marrouchi requested changes Jan 14, 2025
View reviewed changes
api/src/extensions/channels/web/base-web-channel.ts Outdated Show resolved Hide resolved
api/src/chat/services/chat.service.ts Outdated Show resolved Hide resolved
api/src/chat/services/chat.service.ts Outdated Show resolved Hide resolved
api/src/chat/services/bot.service.ts Outdated Show resolved Hide resolved
api/src/chat/services/bot.service.spec.ts Outdated Show resolved Hide resolved
api/src/chat/services/bot.service.spec.ts Outdated Show resolved Hide resolved
@marrouchi marrouchi merged commit 0211153 into main Jan 15, 2025
5 checks passed
@yassinedorbozgithub yassinedorbozgithub linked an issue Jan 15, 2025 that may be closed by this pull request
🤔 [ISSUE] - Chat Module strictNullChecks issues #545
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamedAliBouhaouala MohamedAliBouhaouala MohamedAliBouhaouala approved these changes

@IkbelTalebHssan IkbelTalebHssan IkbelTalebHssan approved these changes

@marrouchi marrouchi marrouchi approved these changes

Assignees

@yassinedorbozgithub yassinedorbozgithub

Labels
strictNullChecks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - Chat Module strictNullChecks issues
4 participants
@yassinedorbozgithub @marrouchi @IkbelTalebHssan @MohamedAliBouhaouala