fix: NLP module strict null checks issues #544
Conversation
yassinedorbozgithub
force-pushed
the
540-issue-nlp-module-strictnullchecks-issues
branch
from
dbf80b0 to
542a02a
Compare
| @@ -151,7 +151,7 @@ export default abstract class BaseNlpHelper< | |||
| }) | |||
| .concat({ | |||
| entity: 'language', | |||
| value: s.language.code, | |||
| value: s.language!.code, | |||
| }); | |||
There was a problem hiding this comment.
Isn't language supposed to be mandatory
There was a problem hiding this comment.
@yassinedorbozgithub @MohamedAliBouhaouala Can we open a Issue to force the user to set the language for each sample ?
There was a problem hiding this comment.
Issue created ✅ #561
…into 540-issue-nlp-module-strictnullchecks-issues
| @@ -151,7 +151,7 @@ export default abstract class BaseNlpHelper< | |||
| }) | |||
| .concat({ | |||
| entity: 'language', | |||
| value: s.language.code, | |||
| value: s.language!.code, | |||
| }); | |||
There was a problem hiding this comment.
@yassinedorbozgithub @MohamedAliBouhaouala Can we open a Issue to force the user to set the language for each sample ?
| @@ -117,11 +121,11 @@ describe('NlpSampleService', () => { | |||
|
|
|||
| describe('findOneAndPopulate', () => { | |||
| it('should return a nlp Sample with populate', async () => { | |||
| const result = await nlpSampleService.findOneAndPopulate(noNlpSample.id); | |||
| const result = await nlpSampleService.findOneAndPopulate(noNlpSample!.id); | |||
There was a problem hiding this comment.
May encounter the risk of passing 'undefined' as a queried value.
| @@ -167,7 +172,7 @@ describe('NlpSampleService', () => { | |||
|
|
|||
| describe('The deleteCascadeOne function', () => { | |||
| it('should delete a nlp Sample', async () => { | |||
| const result = await nlpSampleService.deleteOne(noNlpSample.id); | |||
| const result = await nlpSampleService.deleteOne(noNlpSample!.id); | |||
There was a problem hiding this comment.
same remark as above
| @@ -128,15 +128,15 @@ export class NlpValueService extends BaseService< | |||
| if ('start' in e && 'end' in e) { | |||
| const word = sampleText.slice(e.start, e.end); | |||
| return ( | |||
| word !== e.value && vMap[e.value].expressions.indexOf(word) === -1 | |||
| word !== e.value && vMap[e.value].expressions?.indexOf(word) === -1 | |||
There was a problem hiding this comment.
may encounter the risk of indexing an undefined object
| ); | ||
| } | ||
| return false; | ||
| }) | ||
| .map((e) => { | ||
| return this.updateOne(vMap[e.value].id, { | ||
| ...vMap[e.value], | ||
| expressions: vMap[e.value].expressions.concat([ | ||
| expressions: vMap[e.value].expressions?.concat([ |
There was a problem hiding this comment.
may encounter the risk of concatenating undefined objects
|
Hi @MohamedAliBouhaouala, i have used the ! symbol as an optimistic strategy inside the .spec.ts files |
Motivation
The motivation of this PR is to resolve NLP Module null checks issues
Fixes #540
Checklist: