Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: load config on runtime #32

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Fix: load config on runtime #32

merged 3 commits into from
Sep 20, 2024

Conversation

marrouchi
Copy link
Contributor

@marrouchi marrouchi commented Sep 17, 2024

Motivation

We need to push the docker images to dockerhub. To do so, config must be loaded on runtime.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (Storybook)
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@yassine-sallemi yassine-sallemi changed the title fix: load config on runtime (Partial) Fix: load config on runtime Sep 20, 2024
@yassine-sallemi yassine-sallemi force-pushed the fix/frontend-config-runtime branch from 9bbde8e to cdf8461 Compare September 20, 2024 15:35
@marrouchi marrouchi merged commit e97beb8 into main Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants