Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Insecure randomness #106

Merged
merged 5 commits into from
Sep 30, 2024
Merged

fix: Insecure randomness #106

merged 5 commits into from
Sep 30, 2024

Conversation

yassinedorbozgithub
Copy link
Collaborator

@yassinedorbozgithub yassinedorbozgithub commented Sep 30, 2024 •
edited
Loading

Motivation

The motivation of this PR is to fix unsecured random functions uses cross the API and Frontend App's

Fixes #105

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (Storybook)
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@yassinedorbozgithub yassinedorbozgithub added the security Vulnerabilities, exploits, sensitive data label Sep 30, 2024
@yassinedorbozgithub yassinedorbozgithub self-assigned this Sep 30, 2024
@yassinedorbozgithub yassinedorbozgithub linked an issue Sep 30, 2024 that may be closed by this pull request
🤔 [ISSUE] - Insecure randomness #105
Closed
@yassinedorbozgithub yassinedorbozgithub marked this pull request as draft September 30, 2024 07:37
@yassinedorbozgithub yassinedorbozgithub marked this pull request as ready for review September 30, 2024 08:29
marrouchi
marrouchi requested changes Sep 30, 2024
View reviewed changes
api/src/utils/helpers/safeRandom.ts Outdated Show resolved Hide resolved
@marrouchi marrouchi merged commit d9b8c9b into main Sep 30, 2024
5 checks passed
@marrouchi
Copy link
Contributor

@yassinedorbozgithub Awesome 🔒 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrouchi marrouchi marrouchi approved these changes

Assignees

@yassinedorbozgithub yassinedorbozgithub

Labels
security Vulnerabilities, exploits, sensitive data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - Insecure randomness
2 participants
@yassinedorbozgithub @marrouchi