New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary base classes for Avalonia #52

Merged

HavenDV merged 1 commit into HavenDV:main from noliar:attached_dp

Jul 23, 2024

Contributor

noliar commented Jul 18, 2024

[AttachedDependencyProperty] generated partial class inherit from AvaloniaObject for Avalonia, which can be removed like other platform.

Consider generating both AttachedDependencyProperty and DependencyProperty attributes, such as:
https://github.com/AvaloniaUI/Avalonia/blob/8ea60fefe24b508a7de9fcadd28d67a25c8afb8a/src/Avalonia.Controls/Grid.cs#L2668C5-L2693C1

[DependencyProperty<bool>("ShowGridLines")]
[AttachedDependencyProperty<int, Control>("Column")]
public partial class Grid : Panel
{
}

It'll build failed due to one type inherit from two different base classes.


          remove unnecessary base type

d05db5c

HavenDV merged commit b348405 into HavenDV:main

1 check passed

Owner

HavenDV commented Jul 23, 2024

Thank you for fixing this. And sorry for the long review, it usually happens faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet