Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Released Projects #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Released Projects #3

wants to merge 2 commits into from

Conversation

XoRtY
Copy link
Member

@XoRtY XoRtY commented Sep 16, 2017

Added the released projects, displayed in a bootstrap carousel. Had to import that on the beggining, dont know if its the best way to use it but it was a way to show it working. Later the images of the project will be added too.
The app.css shows so many lines added because it was beautified, but i only added 3 or 4 things on the carousel indicators.

@fntneves
Copy link
Member

fntneves commented Sep 16, 2017

The app.css is a generated file and thus must not be modified, only sass files. Remove the change on app.css and add the appropriate changes in sass files.

Adding a carousel implies a higher importance on the first project than the following projects, since people that visit websites do not have patience and time to wait for the carousel to advance. Therefore, only the first item matters, to them.
Take a look at http://shouldiuseacarousel.com/

Since we do not have many projects, IMO, we should show them directly, without using carousel.
Can you enable this ?

I will ask, also, for the final images, otherwise this PR is incomplete. Or ask me to supply them.

@XoRtY
Copy link
Member Author

XoRtY commented Sep 16, 2017

About the app.css, i'll change it back and, in fact, i won't need to add anything to sass files. The things i needed changed are not useful now that the carousel will not be used.
Actually i don't agree with that idea of the carousel being useless. In our case, the people who will visit our website won't be the "normal" user, won't be the typical user that stumbled on the website and just checked it quickly. I guess that the users on our website will be there with a purpose, and so there will not be a "look at the first one and go" thing.
Anyway, i'll put the three projects side-by-side, and when u can, send me the images of the other two so i can complete the PR.

@fntneves
Copy link
Member

My statements are based on several articles and blog posts that defend that the carousel provides a bad UX, so it should be avoided.

For this case, carousel hides two projects that have the same importance as the first shown project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants