Fixes #2043 - Make sure that filter icon isn't shown in rewards tab #2053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed here that at present we're intentionally trying to hide the filter menu item from the Rewards tab on the tasks screen.
The only time the filter icon is being shown is the first time that you open the Rewards tab, due to the fact that
activeFragment
will always be null when coming from theonPageSelected
callback (since it hasn't had time to inflate and be set yet). This PR moved thegetTaskTypeFromTabPosition
that we can call from the few places it was being duplicated in this Fragment, and makes sure to use the position directly when available so that we don't have to check theactiveFragment
when it could be null.my Habitica User-ID:
caef89d8-3a3d-4d3b-a5ad-67cb0455a56e