Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2043 - Make sure that filter icon isn't shown in rewards tab #2053

Conversation

jsoberg
Copy link
Contributor

@jsoberg jsoberg commented Dec 22, 2023

I noticed here that at present we're intentionally trying to hide the filter menu item from the Rewards tab on the tasks screen.

The only time the filter icon is being shown is the first time that you open the Rewards tab, due to the fact that activeFragment will always be null when coming from the onPageSelected callback (since it hasn't had time to inflate and be set yet). This PR moved the getTaskTypeFromTabPosition that we can call from the few places it was being duplicated in this Fragment, and makes sure to use the position directly when available so that we don't have to check the activeFragment when it could be null.

my Habitica User-ID: caef89d8-3a3d-4d3b-a5ad-67cb0455a56e

…ds tab as expected, even when it's first being switched to and the active fragment is null.
@phillipthelen phillipthelen merged commit d3e288b into HabitRPG:main Feb 7, 2024
2 of 5 checks passed
@saraolson
Copy link
Collaborator

@jsoberg thanks so much for your contribution! I've added record of it to your Habitica profile and granted your 2nd contributor tier 🎉 we'll be releasing it in the 4.3.4 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants