[SW-216413] - Fix new executors shutdown and shutdown_inc flow #716
+30
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirda7
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski,
mgawarkiewicz,
vivekgoe and
afierka-intel
as code owners
nirda7
requested review from
linoybu,
HolyFalafel,
Tiefen-boop,
kiazada,
ulivne and
dudilester
| @@ -96,6 +96,10 @@ def execute_model( | |||
| ) -> Optional[List[SamplerOutput]]: | |||
| raise NotImplementedError | |||
|
|
|||
| def shutdown(self) -> None: | |||
There was a problem hiding this comment.
Why is this method needed here?
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I want to be able to call the worker's shutdown function from the executors.
but the executors are not device specific therefor there should be some generic "shutdown" function to all workers, and I just adjusted the hpu worker shutdown to do something else.
michalkuligowski
requested changes
Jan 22, 2025
| @@ -96,6 +96,10 @@ def execute_model( | |||
| ) -> Optional[List[SamplerOutput]]: | |||
| raise NotImplementedError | |||
|
|
|||
| def shutdown(self) -> None: | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.