Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): allow to add a closure as a middleware in client #1182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(client): allow to add a closure as a middleware in client #1182

wants to merge 1 commit into from

Conversation

joelwurtz
Copy link
Contributor

@joelwurtz joelwurtz commented Jan 17, 2025 •
edited
Loading

Ref #1181

This PR allow an user to pass a closure as a middleware.

@joelwurtz joelwurtz marked this pull request as ready for review January 17, 2025 13:01
@joelwurtz joelwurtz mentioned this pull request Jan 17, 2025
Closed
@fakeshadow
Copy link
Collaborator

We would want to wait for Rust 1.85 which stables true async closure at language level. The AsyncFn trait hack does not really work with closures it only supports function on stable channel right now.
There will be a major library release which would be bump MSRV to 1.85 at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelwurtz @fakeshadow