Improve Logging (again) for Unread Packet Data #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge data methods together
ghzdude
added
type: refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
tracks active data codes and relevant objects, then logs them after reading data
Implementation Details
an int list and object fields were added to ISyncedTileEntity, along with methods to manipulate them
they might be better in a class perhaps?
actually made sure steam boilers don't invade the world
prints active data codes as a path like:
... [SYNC_MTE_TRAITS:3 > WORKABLE_ACTIVE:83] ...Outcome
data is logged even better than before
steam boilers do not take over (for now)