Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Electric Wire Cutters have consistent item IDs #2782

Open
wants to merge 1 commit into
base: 1.20.1
Choose a base branch
from

Conversation

GirixK
Copy link

@GirixK GirixK commented Jan 23, 2025

What

The item ID of electric wire cutters was for example "iv_%s_wirecutter", which is inconsistent with the non-electric version, as well as the tag #forge:tools/wire_cutters

Outcome

Old New
image image

Note the ID changed

Potential Compatibility Issues

This will cause all existing items to cease existence

@GirixK GirixK requested a review from a team as a code owner January 23, 2025 08:48
@krossgg krossgg added Do Not Merge DO NOT MERGE THIS PR YET! type: refactor Suggestion to refactor a section of code labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge DO NOT MERGE THIS PR YET! type: refactor Suggestion to refactor a section of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants