Rewrite biome coloring to not require rendering mod patches #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embeddedt
force-pushed
the
rewrite-biome-colors
branch
from
080348f to
d38adba
Compare
screret
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the environmental hazard coloring to
BiomeColors, which avoids the need to patchBlockColorsand rendering mods separately, and avoids the need to check what type of block is being colored inBlockColors.I've also made the maps in
EnvironmentalHazardClientHandlerconcurrent as they will be read on multiple threads and are not read-only. This fix is unrelated to the previous change.