Add magnet filters #2769
Open
Add magnet filters #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the ability to set a normal/tag filter in every magnet.
Implementation Details
Doesn't support smart filters because the player isn't an Electrolyzer/Centrifuge/Sifter.
Stores a filter tag in the magnets NBT tag and read/write to it using the existing filter methods via a mock
ItemStack.Added a filter check in the last stage before item pickup by the magnet.
Shift r-click toggles the magnet (as it used to), r-click opens the filter editor gui, there's a button at the top right to switch filter modes.
Outcome
Resolves #2418
Additional Information
Editor gui images:
