Make solvent spray can give default color. #2732
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make the solvent spray can make GT paintables have no set color, rather than explicitly setting the color to match the default color. Without this, the Jade tooltip for the block would show the block as colored with an explicit color, and the block would not match changes to the default color in new versions of the mod/modpack.
Implementation Details
To address the issue with the tooltip, it could have been hidden if the color matches the default. However, given the difference in behavior when the default changes, I think it makes sense to show an explicitly set default color.
Outcome
Using the solvent spray on a machine block will no longer show an explicit color in the Jade tooltip.