make event members private with getter/setter

Grasscutters · Oct 28, 2023 · aa99e7f · aa99e7f
1 parent e91e797
commit aa99e7f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/main/java/emu/grasscutter/scripts/SceneScriptManager.java b/src/main/java/emu/grasscutter/scripts/SceneScriptManager.java
@@ -443,9 +443,9 @@ private void init() {
         var event = new SceneMetaLoadEvent(getScene());
         event.call();
 
-        if (event.hasOverride) {
-            // Group grids should not be cached when a scene group
-            // override is in effect. Otherwise, when the server
+        if (event.isOverride()) {
+            // Group grids should not be cached to disk when a scene
+            // group override is in effect. Otherwise, when the server
             // next runs without that override, the cached content
             // will not make sense.
             noCacheGroupGridsToDisk = true;

diff --git a/src/main/java/emu/grasscutter/server/event/game/SceneBlockLoadedEvent.java b/src/main/java/emu/grasscutter/server/event/game/SceneBlockLoadedEvent.java
@@ -2,9 +2,11 @@
 
 import emu.grasscutter.server.event.types.ServerEvent;
 import emu.grasscutter.scripts.data.SceneBlock;
+import lombok.*;
 
+@Getter
 public final class SceneBlockLoadedEvent extends ServerEvent {
-    public SceneBlock block;
+    private SceneBlock block;
 
     public SceneBlockLoadedEvent(SceneBlock block) {
         super(Type.GAME);

diff --git a/src/main/java/emu/grasscutter/server/event/game/SceneMetaLoadEvent.java b/src/main/java/emu/grasscutter/server/event/game/SceneMetaLoadEvent.java
@@ -2,10 +2,12 @@
 
 import emu.grasscutter.game.world.Scene;
 import emu.grasscutter.server.event.types.ServerEvent;
+import lombok.*;
 
+@Getter
 public final class SceneMetaLoadEvent extends ServerEvent {
-    public Scene scene;
-    public boolean hasOverride;
+    private Scene scene;
+    @Setter private boolean override;
 
     public SceneMetaLoadEvent(Scene scene) {
         super(Type.GAME);