Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

Commit

Permalink
fix: Call sub-scripts with bash instead of sh (#714)
Browse files Browse the repository at this point in the history
* feat: move setup scripts closer to posix compliance

* Revert "feat: move setup scripts closer to posix compliance"

This reverts commit c33bcc1.

* just remove the weird double conditional

* remove explicit call with sh so it runs it using env bash
  • Loading branch information
Aaron Gabriel Neyer authored Dec 8, 2022
1 parent f805f8a commit 0618655
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion scripts/configure_delivery.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ REPO_CONNECT_URL="https://console.cloud.google.com/cloud-build/triggers/connect?
echo "Connect your repos: ${REPO_CONNECT_URL}"
read -n 1 -r -s -p $'Once your forked emblem repo is connected, please continue by typing any key.\n'

if [[ -z "${REPO_NAME}" || -z "${REPO_NAME}" ]]
if [[ -z "${REPO_NAME}" ]]
then
continue=1
else
Expand Down
4 changes: 2 additions & 2 deletions setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ fi # skip deploy
if [[ -z "$SKIP_TRIGGERS" ]]; then
echo

sh ./scripts/configure_delivery.sh
./scripts/configure_delivery.sh

fi # skip triggers

Expand All @@ -295,7 +295,7 @@ if [[ -z "$SKIP_AUTH" ]]; then
read -rp "Would you like to configure $(tput bold)$(tput setaf 3)end-user authentication?$(tput sgr0) (y/n) " auth_yesno

if [[ ${auth_yesno} == "y" ]]; then
sh ./scripts/configure_auth.sh
./scripts/configure_auth.sh
else
echo "Skipping end-user authentication configuration. You can configure it later by running:"
echo
Expand Down

0 comments on commit 0618655

Please sign in to comment.