sans-serif backup for system-ui (fix #630) #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #630 - give system-ui font fallbacks (including sans-serif) like label.element.css does, based on this comment
instead of only appending sans-serif
below are screenshots of the 5 areas corresponding to the 5 edits, if someone can test how it looks on their machine before and after
1 of 5: distance element
<figcaption>:2 of 5: metatip element
<figure>:3 of 5: metatip element
[longform]:4 of 5:
vis-bugelement hover tooltip inheritsfont-familyfromol:5 of 5: base element hotkeys
<hotkeys-move>: