Single warning per webpack --watch
#3246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only warn one time per execution of `webpack --watch`
|
Just a note that this was an issue with the original next-pwa package which seems to be unmaintained for a while. https://github.com/DuCanhGH/next-pwa doesn't cause the same log spam. So I no longer need this PR merged but I'll leave it in case others think it makes sense. Feel free to accept or reject |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack --watchImproves #1790, #3180
I'd like to only see this warning printed one time per execution of
next dev. Right now I see it every time a different bundle/batch of server components is compiled or when any code is recompiled and a page reloaded, it's very noisy.I just built and tested this PR locally and I see the GenerateSW warning 4 times (I think
next devmanages multiplewebpack --watchprocesses behind the scenes for the different server and client packages, etc...) but after that initial warning it was quiet.If maintainers don't want to accept this PR as default behavior, I can also change this PR to check for an environment variable like
__WB_ONLY_WARN_ONCEor something like that. Just let me know