Gracefully handle plugin load errors #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This most notably improves the case where stale entry points metadata refers to a nonexistent applet (e.g. because it was removed, or because the applet was developed in a different branch of an editable install), which before this commit entirely breaks the CLI. This commit catches load errors and displays a nice error message in the UI. This commit also improves help text for plugins with unmet requirements.
Merged
via the queue into
GlasgowEmbedded:main
with commit Oct 24, 2023
646ea55
16 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This most notably improves the case where stale entry points metadata refers to a nonexistent applet (e.g. because it was removed, or because the applet was developed in a different branch of an editable install), which before this commit entirely breaks the CLI. This commit catches load errors and displays a nice error message in the UI.
This commit also improves help text for plugins with unmet requirements.