Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target.hardware: whitelist HOME on Linux #388

Closed
wants to merge 1 commit into from
Closed

target.hardware: whitelist HOME on Linux #388

wants to merge 1 commit into from

Conversation

attie
Copy link
Member

@attie attie commented Aug 5, 2023 •
edited
Loading

This resovles errors when nextpnr-ice40 tries to create directories in the rootfs (follow on from #384)

See: YosysHQ/oss-cad-suite-build#75

@attie
target.hardware: whitelist HOME on Linux
68e0919 
This resovles errors when nextpnr-ice40 tries to create directories in
the rootfs.

See: YosysHQ/oss-cad-suite-build#75
@attie attie requested a review from whitequark as a code owner August 5, 2023 01:10
@whitequark
Copy link
Member

Absolutely not, this negates the point of doing hermetic builds.

@whitequark whitequark closed this Aug 5, 2023
@whitequark
Copy link
Member

The reason I whitelisted $PROCESSOR_ARCHITECTURE is that you can already get that information in a number of other ways, so it doesn't really make any difference. If a toolchain for some reason messes with $HOME this is a bug in the toolchain, plain and simple. And if you are hitting an issue with hermetic builds pulling in some sort of unexpected impurity, the solution is not to whitelist the impurity, because that is a route to breaking our caching scheme.

@attie attie deleted the whitelist-home branch August 5, 2023 15:43
@attie
Copy link
Member Author

attie commented Aug 5, 2023 •
edited
Loading

Oh, apologies. I thought $HOME would be benign enough...

So we're hoping / depending on YosysHQ/oss-cad-suite-build#75 to resolve the issue?

@whitequark
Copy link
Member

Oh, apologies. I thought $HOME would be benign enough...

No, absolutely not! $HOME with its various configuration files is a prime example of what should not be in the builder environment.

So we're hoping / depending on YosysHQ/oss-cad-suite-build#75 to resolve the issue?

Why not write a pull request for oss-cad-suite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark Awaiting requested review from whitequark whitequark is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attie @whitequark