Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: color cannot be null, fix bug on edit, move & remove of device_feature #2201

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Jan 20, 2025

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Fix #2189

Copy link

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 16d43c6
Status: ✅  Deploy successful!
Preview URL: https://1c258ce1.gladys-plus.pages.dev
Branch Preview URL: https://fix-default-color-bug-chart.gladys-plus.pages.dev

View logs

Copy link

relativeci bot commented Jan 20, 2025

#2954 Bundle Size — 10.41MiB (~+0.01%).

16d43c6(current) vs 04c1528 master#2952(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#2954
     Baseline
#2952
Regression  Initial JS 5.64MiB(+0.01%) 5.64MiB
No change  Initial CSS 304.89KiB 304.89KiB
No change  Cache Invalidation 54.07% 54.07%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1511 1511
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2954
     Baseline
#2952
Regression  JS 7.43MiB (~+0.01%) 7.43MiB
No change  IMG 2.54MiB 2.54MiB
No change  CSS 321.79KiB 321.79KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.79KiB 17.79KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch fix-default-color-bug-chartProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@Terdious Terdious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in real and debug to observe the behavior it seems very good to me. No more problem when changing the 1st color, and when the same color is selected several times.
The bug of the issue, which was presented at the creation is not present (but for my part, by following the issue I had not managed to reproduce it ... ^^

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (6326203) to head (16d43c6).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2201   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         876      876           
  Lines       14432    14432           
=======================================
  Hits        14221    14221           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Gilles Pierre-Gilles merged commit 43dac59 into master Jan 23, 2025
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the fix-default-color-bug-chart branch January 23, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants